Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(interactions): Interactions Refactor #1309

Closed
wants to merge 127 commits into from

Conversation

DonovanDMC
Copy link
Contributor

@DonovanDMC DonovanDMC commented Nov 28, 2021

Currently interactions can be hard to use due to the way the types have been made. This pull request completely rewrites most things surrounding interactions.

To Use In Projects
npm i DonovanDMC/eris#interactions-rewrite

I'd also recommend looking into everything and everything-v10

@DonovanDMC DonovanDMC changed the title Rewrite Some Interaction Types Various Interactions Changes Nov 28, 2021
Copy link
Contributor

@eritbh eritbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one plural type name, also found a bug from the original implementation that should be corrected

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
eritbh
eritbh previously approved these changes Nov 29, 2021
DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request Dec 9, 2021
@bsian03 bsian03 changed the title Various Interactions Changes refactor(interactions): Redo types and remove unnecessary data Dec 20, 2021
index.d.ts Outdated Show resolved Hide resolved
@DonovanDMC DonovanDMC changed the title refactor(interactions): Redo types and remove unnecessary data refactor(interactions): Interactions Refactor Jun 18, 2022
@DonovanDMC DonovanDMC force-pushed the interactions-rewrite branch 2 times, most recently from 3bb016f to 09aaa12 Compare July 5, 2022 16:44
@DonovanDMC
Copy link
Contributor Author

Don't mind the force pushing mess, I somehow managed to cherry pick the new dev commits instead of merging them some time back, they've been properly merged in now

@DonovanDMC DonovanDMC self-assigned this Aug 20, 2022
@DonovanDMC DonovanDMC closed this Aug 29, 2022
@DonovanDMC DonovanDMC deleted the interactions-rewrite branch August 29, 2022 00:30
Jam-Manbo pushed a commit to Manbo-js/manbo that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants